refactor: make retry fallbacks and sqlite pooling configurable#46
Conversation
Remove baked-in fallback model IDs from retry defaults and cover the new option-based fallback and strategy configuration with focused tests.
Keep serialized access as the default while allowing callers to opt into a larger pool, and lock that behavior down with targeted storage tests.
Keep the repository layout example aligned with the current top-level structure after the CLI path was removed from the tree.
There was a problem hiding this comment.
[DUPLICATE — superseded by review at id PRR_kwDOSQcw4M8AAAABDhLR9Q 2026-06-19T07:57:35Z.
Removing this entry entirely is gated by GitHub: non-pending reviewed submissions cannot be deleted via API. Please use the latest review for current feedback.]
—old body, kept for history:—
Approving content — clean refactor that aligns with eyrie zero-opinions design. Tests cover the decision tree and bad-config guards. CI fully green.
Nits: WithFallback silent no-op, missing CHANGELOG entry, consider WithMaxIdleConns.
Must-do: none.
There was a problem hiding this comment.
[DUPLICATE — superseded by review at id PRR_kwDOSQcw4M8AAAABDhLR9Q 2026-06-19T07:57:35Z.
Removing this entry entirely is gated by GitHub: non-pending reviewed submissions cannot be deleted via API. Please use the latest review for current feedback.]
—old body, kept for history:—
Approving content — clean refactor that aligns with eyrie zero-opinions design. Tests cover the decision tree and bad-config guards. CI fully green.
Nits: WithFallback silent no-op, missing CHANGELOG entry, consider WithMaxIdleConns.
Must-do: none.
Patel230
left a comment
Patel230
left a comment
There was a problem hiding this comment.
Approving content — clean refactor that aligns with eyrie zero-opinions design. Tests cover the decision tree and bad-config guards. CI fully green.
Nits (non-blocking):
- codeagent/retry.go WithFallback silently no-ops on unknown errorType; doc-link classifyError
- storage/sqlite.go consider WithMaxIdleConns later
- No CHANGELOG entry
Must-do: none.
1 participant
Summary
Test plan
Made with Cursor